Skip to content

TYP: check_untyped_defs pandas/io/sql.py #30661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2020
Merged

TYP: check_untyped_defs pandas/io/sql.py #30661

merged 1 commit into from
Jan 4, 2020

Conversation

simonjayhawkins
Copy link
Member

pandas\io\sql.py:785: error: "insert" of "list" does not return a value
pandas\io\sql.py:1450: error: "insert" of "list" does not return a value

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Jan 3, 2020
@jbrockmendel
Copy link
Member

LGTM

@WillAyd WillAyd added this to the 1.0 milestone Jan 4, 2020
@WillAyd WillAyd merged commit bd15c59 into pandas-dev:master Jan 4, 2020
@WillAyd
Copy link
Member

WillAyd commented Jan 4, 2020

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the pandas/io/sql.py branch January 4, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jbrockmendel @WillAyd