Skip to content

DOC: Cleaned pandas/_libs/algos.pyx docstrings #30155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2019
Merged

DOC: Cleaned pandas/_libs/algos.pyx docstrings #30155

merged 2 commits into from
Dec 10, 2019

Conversation

@ShaharNaveh
Copy link
Contributor

@ShaharNaveh ShaharNaveh commented Dec 9, 2019 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

jbrockmendel
jbrockmendel reviewed Dec 9, 2019
View reviewed changes
@jbrockmendel jbrockmendel added the Typing type annotations, mypy/pyright type checking label Dec 9, 2019
WillAyd
WillAyd approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending conversation on annotation

@WillAyd WillAyd added this to the 1.0 milestone Dec 9, 2019
@ShaharNaveh ShaharNaveh changed the title TYP: pandas/_libs/algos.pyx DOC: Cleaned pandas/_libs/algos.pyx docstrings Dec 10, 2019
simonjayhawkins
simonjayhawkins approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MomIsBestFriend lgtm. ping on green.

@simonjayhawkins simonjayhawkins added Docs and removed Typing type annotations, mypy/pyright type checking labels Dec 10, 2019
@ShaharNaveh
Copy link
Contributor Author

ping @simonjayhawkins

@simonjayhawkins simonjayhawkins merged commit 19cefc1 into pandas-dev:master Dec 10, 2019
@simonjayhawkins
Copy link
Member

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the TYP-libs-algos branch December 10, 2019 12:27
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
DOC: Cleaned pandas/_libs/algos.pyx docstrings (pandas-dev#30155)
9e5fb13
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
DOC: Cleaned pandas/_libs/algos.pyx docstrings (pandas-dev#30155)
40cc0d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@WillAyd WillAyd WillAyd approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ShaharNaveh @simonjayhawkins @WillAyd @jbrockmendel