Skip to content

CI: Use conda for 3.8 build #29696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2019
Merged

CI: Use conda for 3.8 build #29696

merged 4 commits into from
Nov 19, 2019

Conversation

@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Nov 18, 2019 •
edited
Loading

Closes #29001

@jbrockmendel
Copy link
Member

jbrockmendel commented Nov 18, 2019

nice

@TomAugspurger TomAugspurger added the CI Continuous Integration label Nov 18, 2019
@TomAugspurger TomAugspurger added this to the 1.0 milestone Nov 18, 2019
@jbrockmendel
Copy link
Member

jbrockmendel commented Nov 18, 2019

LGTM

datapythonista
datapythonista approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

WillAyd
WillAyd reviewed Nov 19, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minor question that may not matter

.travis.yml
# Exclude the default Python 3.5 build
- python: 3.5

include:
Copy link
Member

@WillAyd WillAyd Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for changing this to trusty? Isn’t that an older image?

Copy link
Contributor Author

@TomAugspurger TomAugspurger Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database services weren't starting up with bionic. Haven't looked into the differences at all.

@jreback jreback merged commit a39d9c8 into pandas-dev:master Nov 19, 2019
@jreback
Copy link
Contributor

jreback commented Nov 19, 2019

thanks @TomAugspurger

@TomAugspurger TomAugspurger deleted the 3.8-dev-ci branch November 19, 2019 14:48
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@TomAugspurger @proost
CI: Use conda for 3.8 build (pandas-dev#29696)
7e924a4
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@TomAugspurger @proost
CI: Use conda for 3.8 build (pandas-dev#29696)
7cc9c71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd left review comments

@datapythonista datapythonista datapythonista approved these changes

Assignees

No one assigned

Labels

CI Continuous Integration

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

CI: Integrate 3.8 builds

5 participants

@TomAugspurger @jbrockmendel @jreback @WillAyd @datapythonista