REF: align transform logic flow #29672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Nov 17, 2019
| if not isinstance(func, str): | ||
| return self._transform_general(func, *args, **kwargs) | ||
|
|
||
| elif func not in base.transform_kernel_whitelist: |
There was a problem hiding this comment.
would it be possible to consolidate this logic into the base class to keep this DRY?
There was a problem hiding this comment.
im optimistic about this
There was a problem hiding this comment.
do you have a strong preference for doing this in this PR? im trying to keep the scope narrow to avoid conflicting with #29124.
|
thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement SeriesGroupBy._transform_general to match DataFrameGroupBy._transform_general, re-arrange the checks within the two
transformmethods to be in the same order and be more linear. Make the two _transform_fast methods have closer-to-matching signatures