Skip to content

GH28337: Period index doesn't handle reindexing with a non-period index #28354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2019
Merged

GH28337: Period index doesn't handle reindexing with a non-period index #28354

merged 3 commits into from
Sep 10, 2019

Conversation

@christopherzimmerman
Copy link
Contributor

@christopherzimmerman christopherzimmerman commented Sep 9, 2019 •
edited by jreback
Loading

closes #28323
closes #28337

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Adds a workaround to allow period indexes to be reindexed with non-period indexes.

@jreback jreback added Period Period data type Indexing Related to indexing on series/frames, not to indexes themselves labels Sep 9, 2019
jreback
jreback requested changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you are closing #28323, can you an a replicating test as well

gfyoung
gfyoung approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback : Over to you again

@WillAyd WillAyd added this to the 1.0 milestone Sep 10, 2019
WillAyd
WillAyd requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit but otherwise lgtm

@jreback jreback merged commit 2164af5 into pandas-dev:master Sep 10, 2019
@jreback
Copy link
Contributor

jreback commented Sep 10, 2019

thanks @christopherzimmerman

@christopherzimmerman christopherzimmerman deleted the GH28337 branch September 10, 2019 14:15
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@christopherzimmerman @proost
GH28337: Period index doesn't handle reindexing with a non-period ind…
922798a 
…ex (pandas-dev#28354)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@christopherzimmerman @proost
GH28337: Period index doesn't handle reindexing with a non-period ind…
01ac9ac 
…ex (pandas-dev#28354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd requested changes

@jreback jreback jreback approved these changes

+1 more reviewer

@gfyoung gfyoung gfyoung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Period Period data type

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

reindex with Period results in NaN pivot_table with margins=True shows NaN with Period columns

4 participants

@christopherzimmerman @jreback @WillAyd @gfyoung