BUG: set_precision format fixed (#13257) #27934

AntonioAndraues · 2019-08-15T14:32:22Z

closes Pandas style.set_precision not working as expected #13257
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

I've tried to fix the set_precision format, does that fix it?

INPUT -> df.style.set_precision(2)

A	B
1	2.0090
3.2121	4.566

OUTPUT

A	B
1	2.01
3.21	4.57

@ViniGl
@Samuelgranato

pep8speaks · 2019-08-15T14:32:25Z

Hello @AntonioAndraues! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-16 14:57:46 UTC

jbrockmendel · 2019-08-15T18:05:33Z

Can you add a test for this

AntonioAndraues · 2019-08-19T18:33:25Z

Can you add a test for this

I just added a test.
Is that it?

TomAugspurger

Looks good. Can you add a release note to doc/source/whatsnew/v1.0.0.rst under "bug fixes"? Probably the "Other" section.

AntonioAndraues · 2019-08-20T12:53:28Z

Looks good. Can you add a release note to doc/source/whatsnew/v1.0.0.rst under "bug fixes"? Probably the "Other" section.

Done

doc/source/whatsnew/v1.0.0.rst

pandas/io/formats/style.py

TomAugspurger · 2019-09-03T14:49:36Z

Thanks. Looks like there's a merge conflict in 1.0.0.rst, if you could fix that.

AntonioAndraues · 2019-09-05T11:47:49Z

Thanks. Looks like there's a merge conflict in 1.0.0.rst, if you could fix that.
@TomAugspurger
I think i fix it.

TomAugspurger · 2019-09-05T15:40:56Z

CI is failing now. Do your tests need to be updated?

AntonioAndraues · 2019-09-06T14:55:06Z

CI is failing now. Do your tests need to be updated?
@TomAugspurger
I'm sorry forgot to update them...
I think everything will be fine now!

TomAugspurger · 2019-09-10T21:25:37Z

Hmm CI is still failing. Haven't taken a look though.

AntonioAndraues · 2019-09-19T12:39:13Z

Hmm CI is still failing. Haven't taken a look though.
I think CI is failing because some test from others contributors are expecting the older use of style...
Do i change the test?

@TomAugspurger

WillAyd · 2019-09-19T15:26:44Z

If the old test is wrong then for sure should update

WillAyd · 2019-10-11T21:57:46Z

@AntonioAndraues is this still active? If so can you fix up merge conflict?

AntonioAndraues · 2019-10-11T22:11:08Z

@WillAyd Yes. I Will fix it...
Sunday in the afternoon i commit it.

Co-Authored-By: Tom Augspurger <[email protected]>

jreback

lgtm. small changes; ping on green.

pandas/tests/io/formats/test_style.py

doc/source/whatsnew/v1.0.0.rst

WillAyd · 2019-10-22T01:53:47Z

Great thanks @AntonioAndraues - nice PR!

simonjayhawkins · 2019-12-26T14:51:04Z

I think this PR should be identified as a breaking change.

import pandas as pd
pd.__version__
df = pd.DataFrame([0.1])
df
df.style.highlight_min()

in pandas 0.25.1

on master

AntonioAndraues force-pushed the issue-13257 branch 4 times, most recently from 751c317 to 65fba0e Compare August 19, 2019 18:31

AntonioAndraues force-pushed the issue-13257 branch from 65fba0e to 790327d Compare August 19, 2019 20:20

TomAugspurger added this to the 1.0 milestone Aug 19, 2019

TomAugspurger added Output-Formatting __repr__ of pandas objects, to_string Code Style Code style, linting, code_checks labels Aug 19, 2019

TomAugspurger reviewed Aug 19, 2019

View reviewed changes

AntonioAndraues force-pushed the issue-13257 branch from 790327d to e513938 Compare August 20, 2019 12:49

AntonioAndraues force-pushed the issue-13257 branch 2 times, most recently from 8931f62 to b7d8fc8 Compare August 21, 2019 16:29

TomAugspurger reviewed Aug 21, 2019

View reviewed changes

doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved

AntonioAndraues force-pushed the issue-13257 branch 2 times, most recently from 708b140 to 0aeb419 Compare August 22, 2019 12:17

TomAugspurger reviewed Aug 23, 2019

View reviewed changes

doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved

AntonioAndraues force-pushed the issue-13257 branch from ff08a18 to 187df52 Compare August 23, 2019 18:58

simonjayhawkins reviewed Aug 23, 2019

View reviewed changes

pandas/io/formats/style.py Outdated Show resolved Hide resolved

AntonioAndraues force-pushed the issue-13257 branch from 187df52 to ec08677 Compare September 3, 2019 11:48

AntonioAndraues force-pushed the issue-13257 branch 2 times, most recently from d9c7550 to ec08677 Compare September 19, 2019 11:22

AntonioAndraues force-pushed the issue-13257 branch 3 times, most recently from 2636b5d to 13ac21a Compare September 19, 2019 11:41

BUG: set_precision format fixed (pandas-dev#13257)

e74e5cb

Co-Authored-By: Tom Augspurger <[email protected]>

AntonioAndraues force-pushed the issue-13257 branch 4 times, most recently from 8596e7c to 9896176 Compare October 16, 2019 10:49

jreback requested changes Oct 16, 2019

View reviewed changes

pandas/tests/io/formats/test_style.py Show resolved Hide resolved

doc/source/whatsnew/v1.0.0.rst Outdated Show resolved Hide resolved

AntonioAndraues added 2 commits October 16, 2019 11:51

Merge remote-tracking branch 'upstream/master'

6fb3760

change to IO and add comment

5c80570

AntonioAndraues force-pushed the issue-13257 branch from 14baf9f to 5c80570 Compare October 16, 2019 14:57

jreback approved these changes Oct 17, 2019

View reviewed changes

simonjayhawkins added IO HTML read_html, to_html, Styler.apply, Styler.applymap and removed Code Style Code style, linting, code_checks labels Oct 21, 2019

WillAyd approved these changes Oct 22, 2019

View reviewed changes

WillAyd merged commit ef77b57 into pandas-dev:master Oct 22, 2019

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019

BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)

cf22fcb

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019

BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)

8442843

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)

b4d3902

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019

BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)

d747932

bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020

BUG: set_precision format fixed (pandas-dev#13257) (pandas-dev#27934)

c8816d4

ymzayek mentioned this pull request Apr 18, 2023

[MAINT] remove comment relative to pandas precision bug nilearn/nilearn#3698

Merged

Uh oh!

BUG: set_precision format fixed (#13257) #27934

BUG: set_precision format fixed (#13257) #27934

Uh oh!

Conversation

AntonioAndraues commented Aug 15, 2019 • edited by WillAyd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

INPUT -> df.style.set_precision(2)

OUTPUT

Uh oh!

pep8speaks commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2019-10-16 14:57:46 UTC

Uh oh!

jbrockmendel commented Aug 15, 2019

Uh oh!

AntonioAndraues commented Aug 19, 2019

Uh oh!

TomAugspurger left a comment

Choose a reason for hiding this comment

Uh oh!

AntonioAndraues commented Aug 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TomAugspurger commented Sep 3, 2019

Uh oh!

AntonioAndraues commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomAugspurger commented Sep 5, 2019

Uh oh!

AntonioAndraues commented Sep 6, 2019

Uh oh!

TomAugspurger commented Sep 10, 2019

Uh oh!

AntonioAndraues commented Sep 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WillAyd commented Sep 19, 2019

Uh oh!

WillAyd commented Oct 11, 2019

Uh oh!

AntonioAndraues commented Oct 11, 2019

Uh oh!

jreback left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

WillAyd commented Oct 22, 2019

Uh oh!

simonjayhawkins commented Dec 26, 2019

Uh oh!

Uh oh!

AntonioAndraues commented Aug 15, 2019 •

edited by WillAyd

Loading

pep8speaks commented Aug 15, 2019 •

edited

Loading

AntonioAndraues commented Sep 5, 2019 •

edited

Loading

AntonioAndraues commented Sep 19, 2019 •

edited

Loading