Skip to content

Conversation

@sparalic
Copy link
Contributor

@datapythonista : Add CoC to README file

@TomAugspurger
Copy link
Contributor

Sorry about the CI failures again @sparalic. If you merge master and push, things should be fixed

$ git fetch upstream
$ git merge upstream/matser
$ # git add and commit stuff
$ git push origin pandas-coc

You can also put in @gfyoung's request change at the same time if you want

@sparalic
Copy link
Contributor Author

@TomAugspurger and @gfyoung thank you for all of your help. @TomAugspurger, I tried merging with the master and pushing as you suggested, but some of the CI test failed again.

@gfyoung
Copy link
Member

gfyoung commented Aug 13, 2019

@sparalic : I restarted the failing build for you to see if the failure goes away. If not, you should merge with master and push.

Co-Authored-By: Marc Garcia <[email protected]>
@sparalic
Copy link
Contributor Author

@datapythonista and @gfyoung thank you!

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @sparalic

@TomAugspurger
Copy link
Contributor

You are just not having luck with our CI @sparalic 😄 The windows failure is unrelated. Tracking it in #27902.

This is good to merge once the doc build passes.

@TomAugspurger TomAugspurger merged commit 80a7a45 into pandas-dev:master Aug 13, 2019
@TomAugspurger
Copy link
Contributor

Thanks @sparalic!

quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
* update README file

Co-Authored-By: Marc Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants