BUG: Period/DateTime slicing and setitem fixes (fixes #2782, #2788, #2789) #2785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also fixes #2788, with test coverage in test_series.py |
|
also fixes #2789, with test coverage (make sure to rebuild extensions) |
ghost
assigned
changhiskhan
added a commit
that referenced
this pull request
Feb 9, 2013
|
Cherry-picked with a tiny tweak. Thanks a lot for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2782
simple fix...can't see any reason why the original code was doing what it was, especially since indices are immutable
added test coverage in test_series.py