BUG: boxplot does not work when data has datetime column #27846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Regression
gfyoung
reviewed
Aug 9, 2019
pandas/plotting/_matplotlib/core.py
Outdated
| # GH22799, exclude datatime type for boxplot | ||
| include_type = [np.number, "datetime", "datetimetz", "timedelta"] | ||
| if self._kind == "box": | ||
| include_type.remove("datetime") |
Contributor
There was a problem hiding this comment.
Does datetimetz work? Or does it need to be excluded here too?
Contributor
Author
There was a problem hiding this comment.
ahh, yeah, should exclude datetime-like... thanks for pointing out! @TomAugspurger
Contributor
TomAugspurger
left a comment
TomAugspurger
left a comment
There was a problem hiding this comment.
Small comment on the release not. LGTM otherwise.
Contributor
|
Thanks @charlesdong1991! |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff