BUG: fix to_datetime(dti, utc=True) #27733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 4, 2019
mroeschke
requested changes
Aug 4, 2019
Member
mroeschke
left a comment
mroeschke
left a comment
There was a problem hiding this comment.
Probably needs a whatsnew entry
Member
Author
|
updated with whatsnew and suggested edits |
jreback
requested changes
Aug 4, 2019
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. small comments, ping on green.
doc/source/whatsnew/v0.25.1.rst
Outdated
| Datetimelike | ||
| ^^^^^^^^^^^^ | ||
|
|
||
| - Bug in :func:`to_datetime` where passing a timezone-naive :class:`DatetimeArray` or :class:`DatetimeIndex` and utc=True would incorrectly return a timezone-naive result (:issue:`27733`) |
Contributor
There was a problem hiding this comment.
can you put utc=True in double-back quotes
mroeschke
reviewed
Aug 4, 2019
| return DatetimeIndex(arg, tz=tz, name=name) | ||
| except ValueError: | ||
| pass | ||
| elif tz: |
Member
There was a problem hiding this comment.
I think this would fail if a user passes to_datetime(np.array([...], dtype='datetime64[ns]'), utc=True)?
I was thinking more:
if box:
if not isinstance(arg, (DatetimeArray, ...)):
....
elif tz:
...
Member
Author
There was a problem hiding this comment.
>>> arr = np.arange(2).astype('datetime64[ns]')
>>> to_datetime(arr, utc=True)
DatetimeIndex(['1970-01-01 00:00:00+00:00', '1970-01-01 00:00:00.000000001+00:00'], dtype='datetime64[ns, UTC]', freq=None)
or are you suggesting that this is wrong because box=True was not passed?
Member
There was a problem hiding this comment.
Oh! It does work. box=True is the default so this looks correct.
jreback
approved these changes
Aug 5, 2019
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm, over to @mroeschke
mroeschke
approved these changes
Aug 5, 2019
Member
|
Thanks @jbrockmendel |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 5, 2019
WillAyd
pushed a commit
that referenced
this pull request
Aug 6, 2019
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
* BUG: fix to_datetime(dti, utc=True) * whatsnew, suggested edits * parametrize * backquotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffATM
to_datetime(naive_dti, utc=True)returns naive incorrect, same for naiveDatetimeArray