REF: Avoid dispatching Series ops to pd.Index #27268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 6, 2019
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
small comment, otherwise lgtm.
pandas/core/ops/__init__.py
Outdated
| orig_right = right | ||
| if is_scalar(right): | ||
| # broadcast and wrap in a TimedeltaIndex | ||
| # TODO: possible perf improvement by using NaTD scalar |
Contributor
There was a problem hiding this comment.
I don't think this this is a worthwhile comment here as NaTD is not likely to happen
Member
Author
There was a problem hiding this comment.
I think there's a decent chance we'll implement it for internal use to de-duplicate logic like this.
jreback
added
Clean
Missing-data
jreback
approved these changes
Jul 8, 2019
Contributor
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some semi-circular dispatch logic between non-EA Series and pd.Index ops. This avoids that circularity by implementing the relevant logic directly in the Series implementation. After this I'm going to start migrating the Index implementations to use the Series implementation, after which we will have One True Implementation (also have to migrate RangeIndex and IntegerArray implementations)