Skip to content

Fix Type Annotation in pandas.core.accessor #26147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 21, 2019
Merged

Fix Type Annotation in pandas.core.accessor #26147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
410a0dc
remove the module from mypy.ini and add type annotation
vaibhavhrt Apr 19, 2019
890a57d
Merge branch 'master' into type-annotation-pandas/core/accessor.py
vaibhavhrt Apr 19, 2019
5fd05ae
consistently use `set` for `_accessors` instead of `frozenset`
vaibhavhrt Apr 19, 2019
3952bc8
remove pandas.core.apply from mypy.ini as well because it didn't actu…
vaibhavhrt Apr 19, 2019
8c2be3c
remove unnecessary type annotation
vaibhavhrt Apr 20, 2019
bcb44fc
comment out all unnecessary modules from mypy.ini for testing
vaibhavhrt Apr 20, 2019
dbadecb
remove unnecessary modules from mypy.ini and remove an unused import
vaibhavhrt Apr 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,9 @@ ignore_errors=True
[mypy-pandas.compat.numpy.function]
ignore_errors=True

[mypy-pandas.core.accessor]
ignore_errors=True

[mypy-pandas.core.api]
ignore_errors=True

[mypy-pandas.core.apply]
ignore_errors=True

[mypy-pandas.core.arrays.array_]
ignore_errors=True

Expand All @@ -32,15 +26,9 @@ ignore_errors=True
[mypy-pandas.core.arrays.interval]
ignore_errors=True

[mypy-pandas.core.arrays.numpy_]
ignore_errors=True

[mypy-pandas.core.arrays.period]
ignore_errors=True

[mypy-pandas.core.arrays.sparse]
ignore_errors=True

[mypy-pandas.core.arrays.timedeltas]
ignore_errors=True

Expand Down Expand Up @@ -98,9 +86,6 @@ ignore_errors=True
[mypy-pandas.core.series]
ignore_errors=True

[mypy-pandas.core.sparse.frame]
ignore_errors=True

[mypy-pandas.core.util.hashing]
ignore_errors=True

Expand Down
3 changes: 2 additions & 1 deletion pandas/core/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@
that can be mixed into or pinned onto other pandas classes.

"""
from typing import Set
import warnings

from pandas.util._decorators import Appender


class DirNamesMixin:
_accessors = frozenset()
_accessors = set() # type: Set[str]
_deprecations = frozenset(
['asobject', 'base', 'data', 'flags', 'itemsize', 'strides'])

Expand Down