Skip to content

Conversation

@gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 15, 2019

With all of the great cleanup in this file, let's ensure that it remains nice and tidy.

@gfyoung gfyoung added Code Style Code style, linting, code_checks Clean labels Apr 15, 2019
@gfyoung gfyoung added this to the 0.25.0 milestone Apr 15, 2019
@gfyoung gfyoung force-pushed the flake8-compat-init branch from dc83493 to dba122d Compare April 15, 2019 01:27
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@190a69e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26093   +/-   ##
=========================================
  Coverage          ?   91.94%           
=========================================
  Files             ?      175           
  Lines             ?    52443           
  Branches          ?        0           
=========================================
  Hits              ?    48220           
  Misses            ?     4223           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.5% <100%> (?)
#single 40.75% <100%> (?)
Impacted Files Coverage Δ
pandas/compat/__init__.py 93.22% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190a69e...dba122d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@190a69e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26093   +/-   ##
=========================================
  Coverage          ?   91.94%           
=========================================
  Files             ?      175           
  Lines             ?    52443           
  Branches          ?        0           
=========================================
  Hits              ?    48220           
  Misses            ?     4223           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.5% <100%> (?)
#single 40.75% <100%> (?)
Impacted Files Coverage Δ
pandas/compat/__init__.py 93.22% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 190a69e...dba122d. Read the comment docs.

@WillAyd WillAyd merged commit 4e7e7f0 into pandas-dev:master Apr 15, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 15, 2019

Thanks @gfyoung !

yhaque1213 pushed a commit to yhaque1213/pandas that referenced this pull request Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Code Style Code style, linting, code_checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants