Skip to content

Conversation

@gwrome
Copy link
Contributor

@gwrome gwrome commented Apr 12, 2019

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #26071 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26071      +/-   ##
==========================================
- Coverage   91.89%   91.89%   -0.01%     
==========================================
  Files         175      175              
  Lines       52509    52513       +4     
==========================================
  Hits        48255    48255              
- Misses       4254     4258       +4
Flag Coverage Δ
#multiple 90.45% <100%> (ø) ⬆️
#single 40.75% <85.71%> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 97.69% <100%> (ø) ⬆️
pandas/core/arrays/interval.py 93.12% <100%> (ø) ⬆️
pandas/core/arrays/integer.py 96.34% <100%> (+0.01%) ⬆️
pandas/core/arrays/timedeltas.py 88.29% <100%> (+0.02%) ⬆️
pandas/core/arrays/period.py 98.54% <100%> (ø) ⬆️
pandas/core/arrays/array_.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a15069...b39f7fc. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #26071 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26071      +/-   ##
==========================================
- Coverage   91.97%   91.96%   -0.01%     
==========================================
  Files         175      175              
  Lines       52368    52378      +10     
==========================================
+ Hits        48164    48170       +6     
- Misses       4204     4208       +4
Flag Coverage Δ
#multiple 90.52% <100%> (ø) ⬆️
#single 40.7% <73.33%> (-0.14%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/datetimelike.py 97.71% <100%> (+0.01%) ⬆️
pandas/core/arrays/integer.py 96.35% <100%> (+0.01%) ⬆️
pandas/core/arrays/interval.py 93.06% <100%> (ø) ⬆️
pandas/_typing.py 100% <100%> (ø) ⬆️
pandas/core/arrays/timedeltas.py 88.61% <100%> (+0.02%) ⬆️
pandas/core/arrays/period.py 98.53% <100%> (ø) ⬆️
pandas/core/arrays/array_.py 100% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9feb3ad...5f840e9. Read the comment docs.

@jschendel jschendel added the Typing type annotations, mypy/pyright type checking label Apr 13, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 25, 2019

@gwrome can you merge master?

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm outside of comment from @jreback

Some of the cast stuff is unfortunate but not sure there is a way to get around that given limitations cited.

@jreback jreback added this to the 0.25.0 milestone Apr 28, 2019
@jreback jreback merged commit f54945e into pandas-dev:master Apr 30, 2019
@jreback
Copy link
Contributor

jreback commented Apr 30, 2019

thanks @gwrome

@gwrome gwrome deleted the blacklist-arrays branch April 30, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Type Annotations in pandas.core.arrays

5 participants