Skip to content

Conversation

@gwrome
Copy link
Contributor

@gwrome gwrome commented Apr 6, 2019

Part of #25882

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Apr 6, 2019
@jreback jreback added this to the 0.25.0 milestone Apr 6, 2019
@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #26014 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26014      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52551    52554       +3     
==========================================
- Hits        48256    48255       -1     
- Misses       4295     4299       +4
Flag Coverage Δ
#multiple 90.38% <100%> (ø) ⬆️
#single 40.72% <100%> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 97.69% <100%> (ø) ⬆️
pandas/tseries/offsets.py 96.69% <100%> (ø) ⬆️
pandas/tseries/holiday.py 93.2% <100%> (+0.03%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...57ef2f2. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #26014 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26014      +/-   ##
==========================================
- Coverage   91.82%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52551    52554       +3     
==========================================
- Hits        48256    48255       -1     
- Misses       4295     4299       +4
Flag Coverage Δ
#multiple 90.38% <100%> (ø) ⬆️
#single 40.72% <100%> (-0.13%) ⬇️
Impacted Files Coverage Δ
pandas/tseries/frequencies.py 97.69% <100%> (ø) ⬆️
pandas/tseries/offsets.py 96.69% <100%> (ø) ⬆️
pandas/tseries/holiday.py 93.2% <100%> (+0.03%) ⬆️
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fee91...49db28c. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Apr 7, 2019

lgtm. @WillAyd

@WillAyd WillAyd merged commit 6de8133 into pandas-dev:master Apr 7, 2019
@WillAyd
Copy link
Member

WillAyd commented Apr 7, 2019

Thanks @gwrome !

@gwrome gwrome deleted the blacklist-tseries branch April 8, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix type annotations in pandas.tseries.*

3 participants