Skip to content

Fix type annotation in pandas. version #25949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2019
Merged

Fix type annotation in pandas. version #25949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c419791
remove the module from mypy.ini
vaibhavhrt Apr 1, 2019
5872b7e
type variables of _version.py as indicated by mypy
vaibhavhrt Apr 1, 2019
802873e
remove possible dead code, properly type HANDLERS and type the method…
vaibhavhrt Apr 1, 2019
3ed8317
remove dead code and type the decorator in a minimal way
vaibhavhrt Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ follow_imports=silent
[mypy-pandas.conftest,pandas.tests.*]
ignore_errors=True

[mypy-pandas._version]
ignore_errors=True

[mypy-pandas.compat]
ignore_errors=True

Expand Down
8 changes: 4 additions & 4 deletions pandas/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import re
import subprocess
import sys
from typing import Callable, Dict

from pandas.compat import PY3

Expand Down Expand Up @@ -48,12 +49,11 @@ class NotThisMethod(Exception):
pass


LONG_VERSION_PY = {}
HANDLERS = {}
HANDLERS = {} # type: Dict[str, Dict[str, Callable]]


def register_vcs_handler(vcs, method): # decorator
def decorate(f):
def register_vcs_handler(vcs: str, method: str) -> Callable: # decorator
def decorate(f: Callable) -> Callable:
if vcs not in HANDLERS:
HANDLERS[vcs] = {}
HANDLERS[vcs][method] = f
Expand Down