REF/TST: Finish pytest idiom in parser tests #23863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Refactor
|
Hello @gfyoung! Thanks for submitting the PR.
|
gfyoung
force-pushed
the
pytest-parsers-idiom-done
branch
2 times, most recently
from
424f857 to
94b5524
Compare
Adds more idiom to the following: * parser/common --> parser/test_common * parser/quoting --> parser/test_quoting * parser/usecols --> parser/test_usecols * parser/python_parser_only --> parser/test_python_parser_only Also: * Finally delete parser/test_parsers! * Bug in capture_stdout decorator in which we were forgetting to use compat.wraps. Builds off of pandas-devgh-23712.
gfyoung
force-pushed
the
pytest-parsers-idiom-done
branch
from
94b5524 to
d35a2c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #23863 +/- ##
==========================================
+ Coverage 92.28% 92.29% +<.01%
==========================================
Files 161 161
Lines 51500 51500
==========================================
+ Hits 47528 47533 +5
+ Misses 3972 3967 -5
Continue to review full report at Codecov.
|
|
thanks! |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Adds more idiom to the following: * parser/common --> parser/test_common * parser/quoting --> parser/test_quoting * parser/usecols --> parser/test_usecols * parser/python_parser_only --> parser/test_python_parser_only Also: * Finally delete parser/test_parsers! * Bug in capture_stdout decorator in which we were forgetting to use compat.wraps. Builds off of pandas-devgh-23712.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Adds more idiom to the following: * parser/common --> parser/test_common * parser/quoting --> parser/test_quoting * parser/usecols --> parser/test_usecols * parser/python_parser_only --> parser/test_python_parser_only Also: * Finally delete parser/test_parsers! * Bug in capture_stdout decorator in which we were forgetting to use compat.wraps. Builds off of pandas-devgh-23712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more idiom to the following:
parser/usecols-->parser/test_usecolsparser/quoting-->parser/test_quotingparser/common-->parser/test_commonparser/python_parser_only-->parser/test_python_parser_onlyAlso:
parser/test_parsers! 🎉capture_stdoutin which we forgot to usecompat.wraps.Builds off of #23712.