CI: Check in the CI that assert_raises_regex is not being used

[datapythonista]

Follow up of #23592.

As assert_raises_regexis now deprecated, add to the CI a check to fail if a PR uses it.

[gfyoung]

As assert_raises_regexis not deprecated, add to the CI a check to fail if a PR uses it.

@datapythonista : That's not true. assert_raises_regex is deprecated. That's why I was saying that the need to check for usage was unnecessary. Warnings will be issued if used.

[TomAugspurger]

We still need the check, in case it’s used in a test that’s skipped on the numpydev job.

…

________________________________ From: gfyoung <[email protected]> Sent: Sunday, November 11, 2018 4:32 PM To: pandas-dev/pandas Cc: Tom Augspurger; Comment Subject: Re: [pandas-dev/pandas] CI: Check in the CI that assert_raises_regex is not being used (#23627) As assert_raises_regexis not deprecated, add to the CI a check to fail if a PR uses it. @datapythonista<https://github.com/datapythonista> : That's not correct. assert_raises_regex is deprecated<https://github.com/pandas-dev/pandas/blob/58a59bd606911f11a4f679df18a00cfc25536c30/pandas/util/testing.py#L2576>. That's why I was saying that the need to check for usage was unnecessary. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#23627 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIs6ADp5IiNxjJ4PNNWe1p0M4PuUzks5uuKWIgaJpZM4YYqgS>.

[datapythonista]

I meant now instead of not.

I don't understand what you mean, sorry. I think after all your work replacing assert_raises_regex by pytest.raises now we don't want anyone to use assert_raises_regex anymore, right?

If you agree with that, this PR what it does it just to fail the CI if anyone uses it in a PR. Doesn't this make sense?

[gfyoung]

We still need the check, in case it’s used in a test that’s skipped on the numpydev job.

@TomAugspurger : Ah, that's true. Okay, LGTM then.

[jreback]

lgtm merge on green

[jreback]

you need --includes '.py --includes '*.pyx'' in your grep

Check that the deprecated `assert_raises_regex` is not used (`pytest.raises(match=pattern)` should be used instead)
Binary file pandas/tests/util/__pycache__/test_testing.cpython-36-PYTEST.pyc matches
Binary file pandas/util/__pycache__/testing.cpython-36.pyc matches
Binary file pandas/util/__pycache__/testing.cpython-36.opt-2.pyc matches
Check that the deprecated `assert_raises_regex` is not used (`pytest.raises(match=pattern)` should be used instead) DONE

[datapythonista]

I just did --exclude=.pyc. I don't think it should be used in .pyx or others, but I guess it's saver. Do you think --include=*.py is better?

[jreback]

@datapythonista that's ok as well. I kind of slightly prefer the includes but prob doesn't make much difference here.

[jreback]

ping on green.

[codecov]

Codecov Report

Merging #23627 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #23627      +/-   ##
==========================================
+ Coverage   92.23%   92.23%   +<.01%     
==========================================
  Files         161      161              
  Lines       51288    51322      +34     
==========================================
+ Hits        47304    47337      +33     
- Misses       3984     3985       +1

Flag	Coverage Δ
#multiple	90.62% <ø> (ø)	⬆️
#single	42.3% <ø> (+0.03%)	⬆️

Impacted Files	Coverage Δ
pandas/core/indexes/timedeltas.py	89.29% <0%> (-0.59%)	⬇️
pandas/core/tools/timedeltas.py	98.03% <0%> (-0.15%)	⬇️
pandas/core/indexes/datetimes.py	96.12% <0%> (-0.02%)	⬇️
pandas/core/arrays/datetimes.py	98.44% <0%> (-0.01%)	⬇️
pandas/core/arrays/timedeltas.py	95.08% <0%> (+1.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a59bd...1fea3a4. Read the comment docs.