Skip to content

Conversation

alimcmaster1
Copy link
Member

@pep8speaks
Copy link

Hello @alimcmaster1! Thanks for submitting the PR.

@datapythonista datapythonista added Code Style Code style, linting, code_checks Clean labels Nov 6, 2018
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks @alimcmaster1

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #23534 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23534      +/-   ##
==========================================
- Coverage   92.25%   92.24%   -0.01%     
==========================================
  Files         161      161              
  Lines       51200    51198       -2     
==========================================
- Hits        47232    47230       -2     
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.63% <100%> (-0.01%) ⬇️
#single 42.29% <81.96%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/formats/excel.py 97.4% <100%> (ø) ⬆️
pandas/io/json/normalize.py 96.87% <100%> (ø) ⬆️
pandas/io/formats/style.py 96.69% <100%> (ø) ⬆️
pandas/compat/pickle_compat.py 75.6% <100%> (ø) ⬆️
pandas/io/formats/format.py 97.88% <100%> (ø) ⬆️
pandas/io/json/table_schema.py 98.29% <100%> (ø) ⬆️
pandas/io/formats/console.py 75.75% <100%> (ø) ⬆️
pandas/io/clipboard/clipboards.py 28.23% <100%> (ø) ⬆️
pandas/io/clipboard/windows.py 11.62% <100%> (ø) ⬆️
pandas/compat/numpy/function.py 87.13% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf4c0b6...375050d. Read the comment docs.

@TomAugspurger TomAugspurger merged commit 7d6bd75 into pandas-dev:master Nov 7, 2018
@TomAugspurger
Copy link
Contributor

Thanks!

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Nov 7, 2018
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@alimcmaster1 alimcmaster1 deleted the isort-imports branch December 25, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants