Skip to content

TST: Add test of assignment chaining and dupe cols #23487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

TST: Add test of assignment chaining and dupe cols #23487

merged 1 commit into from
Nov 5, 2018

Conversation

@gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 4, 2018

xref #13017

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Indexing Related to indexing on series/frames, not to indexes themselves Error Reporting Incorrect or improved errors from pandas labels Nov 4, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 4, 2018
@pep8speaks
Copy link

pep8speaks commented Nov 4, 2018

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 4, 2018 •
edited
Loading

Codecov Report

Merging #23487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23487   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51197    51197           
=======================================
  Hits        47220    47220           
  Misses       3977     3977
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ab22f...1888536. Read the comment docs.

jreback
jreback requested changes Nov 4, 2018
View reviewed changes
@gfyoung gfyoung force-pushed the assign-chaining-dupe-cols branch from 7b27b19 to 1888536 Compare November 4, 2018 21:54
@gfyoung
Copy link
Member Author

gfyoung commented Nov 5, 2018

@jreback : Comments addressed, and all is green. PTAL.

@jreback jreback merged commit 19baa61 into pandas-dev:master Nov 5, 2018
@jreback
Copy link
Contributor

jreback commented Nov 5, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the assign-chaining-dupe-cols branch November 6, 2018 04:20
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
@gfyoung @JustinZhengBC
TST: Add test of assignment chaining and dupe cols (pandas-dev#23487)
ed46d6d 
xref pandas-devgh-13017.
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@gfyoung @tm9k1
TST: Add test of assignment chaining and dupe cols (pandas-dev#23487)
0df2793 
xref pandas-devgh-13017.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
TST: Add test of assignment chaining and dupe cols (pandas-dev#23487)
267fd8a 
xref pandas-devgh-13017.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
TST: Add test of assignment chaining and dupe cols (pandas-dev#23487)
d99474e 
xref pandas-devgh-13017.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Error Reporting Incorrect or improved errors from pandas Indexing Related to indexing on series/frames, not to indexes themselves Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

0.24.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gfyoung @pep8speaks @jreback