DOC: Updating str_repeat docstring #22571
Conversation
|
Hello @JesperDramsch! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 02, 2018 at 09:54 Hours UTC |
hahahah |
|
https://travis-ci.org/pandas-dev/pandas/jobs/423383576#L3419 @JesperDramsch : Looks like you have a linting failure here. |
Codecov Report
@@ Coverage Diff @@
## master #22571 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 169 169
Lines 50787 50787
=======================================
Hits 46745 46745
Misses 4042 4042
Continue to review full report at Codecov.
|
|
@JesperDramsch : I like the change! FYI, Anaconda is having some serious servicing issues, so our CI is not going to work at all for the time being. |
|
Alright then I'll chill out and enjoy the view. |
jeffyancey
left a comment
jeffyancey
left a comment
There was a problem hiding this comment.
Basically looks good to me, just a couple questions and observations.
| >>> s | ||
| 0 a | ||
| 1 b | ||
| 2 c |
There was a problem hiding this comment.
I don't know that it is necessary, be I do see that elsewhere in our examples the dtype: object is included beneath the series printout.
| ---------- | ||
| repeats : int or array | ||
| Same value for all (int) or different value per (array) | ||
| repeats : int or sequence of int |
There was a problem hiding this comment.
sequence of int might be fine, and maybe 'sequence' is a term that has a clear definition in the pandas community, but I often see array_like used in the numpy documentation. Not really recommending anything, just curious is sequence is used similarly here, or you were just using to to indicate a list/array/tuple/etc of integers.
|
Finally merging this. We can add improvements from #20634 later on in a new PR. |
|
Thanks @JesperDramsch |
7 participants
No description provided.