REF: multi_take is now able to tackle all list-like (non-bool) cases #21569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobaz
added
Refactor
toobaz
force-pushed
the
allow_more_multi_take
branch
from
145341a to
430a268
Compare
Contributor
|
lgtm. merge on green. |
Codecov Report
@@ Coverage Diff @@
## master #21569 +/- ##
==========================================
- Coverage 91.92% 91.92% -0.01%
==========================================
Files 153 153
Lines 49561 49553 -8
==========================================
- Hits 45559 45551 -8
Misses 4002 4002
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThis is basically a consequence of #21503 - the code path for indexing when
keyis a collection is now the same for multi_take and for single take.(Next step will be to merge the other code paths too, and approach with multi_take all cases in which mutiple axes are being indexed, in whatever fashion)