Skip to content

DOC: update whatsnew 0.23.1 #21387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2018
Merged

DOC: update whatsnew 0.23.1 #21387

merged 1 commit into from
Jun 8, 2018

Conversation

jorisvandenbossche
Copy link
Member

One of the last commits apparently added back the subsections

@jorisvandenbossche jorisvandenbossche added this to the 0.23.1 milestone Jun 8, 2018
@jorisvandenbossche jorisvandenbossche merged commit 0f521ab into pandas-dev:master Jun 8, 2018
@jorisvandenbossche jorisvandenbossche deleted the doc-fixup-whatsnew branch June 8, 2018 16:41
@jorisvandenbossche
Copy link
Member Author

ah, @jreback I see that you actually added that commit to that PR explicitly (I assumed is was due to some rebase or so). I removed the subsections on purpose in #21368, because IMO for such a short list it is not really needed and rather adds noise to the toc (but can certainly be discussed)

jreback
jreback reviewed Jun 8, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added these back because they were completely unmarked

bold is fine too

TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Jun 12, 2018
@jorisvandenbossche @TomAugspurger
DOC: update whatsnew 0.23.1 (pandas-dev#21387)
8c0d56b 
(cherry picked from commit 0f521ab)
TomAugspurger pushed a commit that referenced this pull request Jun 12, 2018
@jorisvandenbossche @TomAugspurger
DOC: update whatsnew 0.23.1 (#21387)
118c501 
(cherry picked from commit 0f521ab)
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
@jorisvandenbossche @david-liu-brattle-1
DOC: update whatsnew 0.23.1 (pandas-dev#21387)
f513015
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@jorisvandenbossche
DOC: update whatsnew 0.23.1 (pandas-dev#21387)
a2c1d32
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
@jorisvandenbossche
DOC: update whatsnew 0.23.1 (pandas-dev#21387)
3a6cd19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.23.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @jreback