Skip to content

Conversation

@adamjstewart
Copy link
Contributor

Newline characters are stripped from the docstring when formatting parameter documentation. Because of this, the docs for the prefix parameter of pandas.get_dummies look like a single run-on sentence. Added a period to the end of the first sentence to fix this.

@WillAyd WillAyd added the Docs label May 31, 2018
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - lgtm

@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #21277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21277   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files         153      153           
  Lines       49543    49543           
=======================================
  Hits        45504    45504           
  Misses       4039     4039
Flag Coverage Δ
#multiple 90.24% <ø> (ø) ⬆️
#single 41.87% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/reshape/reshape.py 99.78% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af5fee...010058a. Read the comment docs.

@jreback jreback added this to the 0.23.1 milestone Jun 1, 2018
@jreback jreback merged commit 4274b84 into pandas-dev:master Jun 1, 2018
@jreback
Copy link
Contributor

jreback commented Jun 1, 2018

thanks!

@adamjstewart adamjstewart deleted the docs/get_dummies branch June 1, 2018 01:28
jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Jun 9, 2018
jorisvandenbossche pushed a commit that referenced this pull request Jun 9, 2018
david-liu-brattle-1 pushed a commit to david-liu-brattle-1/pandas that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants