Skip to content

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 19, 2017

For consistency with read_csv, which uses skipfooter.

For consistency with read_csv, which uses skipfooter.
@gfyoung gfyoung added Deprecate Functionality to remove in pandas IO Excel read_excel, to_excel labels Dec 19, 2017
@gfyoung gfyoung added this to the 0.22.0 milestone Dec 19, 2017
@gfyoung gfyoung force-pushed the excel-skipfooter-deprecate branch 2 times, most recently from f0d2cee to 7045d51 Compare December 19, 2017 06:39
@gfyoung gfyoung changed the title DEPR: Deprecate skip_footer in read_excel [skip ci] DEPR: Deprecate skip_footer in read_excel Dec 19, 2017
@codecov
Copy link

codecov bot commented Dec 19, 2017

Codecov Report

Merging #18836 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18836      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51406       -2     
==========================================
- Hits        47113    47101      -12     
- Misses       4295     4305      +10
Flag Coverage Δ
#multiple 89.49% <100%> (-0.01%) ⬇️
#single 40.84% <100%> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel.py 90.09% <100%> (-0.04%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.68% <0%> (-0.11%) ⬇️
pandas/core/indexes/datetimes.py 95.62% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a7cc9...7045d51. Read the comment docs.

@jreback jreback merged commit 0c07ab2 into pandas-dev:master Dec 19, 2017
@jreback
Copy link
Contributor

jreback commented Dec 19, 2017

thanks!

@gfyoung gfyoung deleted the excel-skipfooter-deprecate branch December 19, 2017 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO Excel read_excel, to_excel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants