Modernize indexes.timedeltas, indexes.datetimeindex #18161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18161 +/- ##
==========================================
+ Coverage 91.41% 91.41% +<.01%
==========================================
Files 163 163
Lines 50132 50123 -9
==========================================
- Hits 45827 45821 -6
+ Misses 4305 4302 -3
Continue to review full report at Codecov.
|
Contributor
|
thsnks |
watercrossing
pushed a commit
to watercrossing/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
(cherry picked from commit 079f678)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
(cherry picked from commit 079f678)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things here. They should be separate PRs, but so it goes.
indexes.datetimes and indexes.periods use a _field_accessor pattern to define several properties in their index classes. This updates TimedeltaIndex to use the same pattern, getting rid of the
_get_fieldmethod that was used before.indexes.datetimes has a _utc() function that I think is designed to lazily import pytz. That ship has sailed elsewhere, so this removes that extra call.