Remove properties from groupby whitelists #17600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 21, 2017
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
i would rather generate these methods than hand code them.
Member
Author
4 tasks
Contributor
|
generating these the current method I agree. However using a real function definition is the correct methodology here; see how we do generated functions in https://github.com/pandas-dev/pandas/blob/master/pandas/core/generic.py#L6568 all with proper doc-strings and such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small piece broken off of #17179, keeping a modicum of forward momentum going.
git diff upstream/master -u -- "*.py" | flake8 --diff