Add vectorized string methods to Series #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API looks great |
|
Hm. Should maybe raise an exception in repeat on numeric data, but how to do so without paying a high performance penalty... |
|
Maybe a hack for now? f0afc3b |
|
Nice, that works for me. Add a test for that and good to go? |
|
yeah, I'm putting in a few more changes to handle unicode where the method was constructed with str.* methods right now. Will push in a little bit |
|
Thanks for the feedback. Merged up and closing relevant issues now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd appreciate any feedback on the API (@takluyver and others), but this makes a lot of sense to me and I'm already finding my fingers falling right onto it. I swear I'm going to start doing more pull requests