MAINT: Refactor Python engine empty line funcs #15946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python engine's _empty and _check_empty methods were uninformative and undocumented. This commit renames them to _is_line_empty and _remove_empty_lines respectively and provides appropriate documentation.
|
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #15946 +/- ##
=======================================
Coverage 90.98% 90.98%
=======================================
Files 145 145
Lines 49556 49556
=======================================
Hits 45091 45091
Misses 4465 4465
Continue to review full report at Codecov.
|
|
@jreback : All green and ready to go. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python engine's
_emptyand_check_emptymethods were uninformative and undocumented.This commit renames them to
_is_line_emptyand_remove_empty_linesrespectively and provides appropriate documentation.xref #15925 (comment)