BUG: Validate the skipfooter parameter in read_csv #15945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Error Reporting
gfyoung
force-pushed
the
skipfooter-validate
branch
from
c05a07e to
385c780
Compare
Previously, the skipfooter parameter was assumed to be an integer, but that was not checked.
gfyoung
force-pushed
the
skipfooter-validate
branch
from
385c780 to
baa3415
Compare
|
yeah been happening in several builds |
|
@jreback : Hmm...okay, let me know once |
Codecov Report
@@ Coverage Diff @@
## master #15945 +/- ##
==========================================
+ Coverage 90.99% 90.99% +<.01%
==========================================
Files 145 145
Lines 49565 49569 +4
==========================================
+ Hits 45101 45105 +4
Misses 4464 4464
Continue to review full report at Codecov.
|
|
@jreback : Oh, seems like the rebuild finished successfully. All green and ready to go now. |
|
i restarted build |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
skipfooterparameter was assumed to be an integer, but that was not checked.xref #15925 (comment)