Skip to content

Conversation

@sahildua2305
Copy link
Contributor

@sahildua2305 sahildua2305 commented Jul 20, 2016

/cc @jreback

@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

ok this is fine. in general no need to open a new PR, just push to the old one.

@jreback jreback added Error Reporting Incorrect or improved errors from pandas MultiIndex labels Jul 20, 2016
@jreback jreback added this to the 0.19.0 milestone Jul 20, 2016
@sahildua2305
Copy link
Contributor Author

@jreback It had conflicts with the base branch. How would you have merged it?

@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

see the contributing docs here and how git works. you simply rebase and fix the conflicts.

@sahildua2305
Copy link
Contributor Author

Ah! Okay.

Actually I tried to rebase on my branch and ran into issues (it included other commits as well), that's why had to close the old PR.

@jreback jreback closed this in 1ce8f8e Jul 20, 2016
@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

thanks!

@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

try git rebase -i origin/master in the future

@sahildua2305
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Error Reporting Incorrect or improved errors from pandas MultiIndex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiIndex.from_arrays() does not check lenghts

2 participants