Skip to content

Conversation

@markroth8
Copy link
Contributor

Includes implementation, unit tests, documentation fixes and whatsnew.

@sinhrks sinhrks added Datetime Datetime data dtype MultiIndex Indexing Related to indexing on series/frames, not to indexes themselves labels Mar 5, 2016
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls use pd. and np., see #9886.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sinhrks, Fixed.

@jreback jreback added this to the 0.18.1 milestone Mar 5, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use double-back ticks around DatetimeIndex (sp as well) (and same around MultiIndex); put the issue reference on the same line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jreback
Copy link
Contributor

jreback commented Mar 5, 2016

looks real nice @markroth8

just some minor doc-comments. pls rebase on master when you get a chance; master now builds correctly.

@jreback
Copy link
Contributor

jreback commented Mar 5, 2016

actually pls also put an example in the this section here as well

@jreback
Copy link
Contributor

jreback commented Mar 13, 2016

pls rebase and i'll have a look

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a min-example here (you can add a sub-section if you'd like to highlite to setup an example and show how it works)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can pretty much use the example for timeseries.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jreback
Copy link
Contributor

jreback commented Mar 20, 2016

@markroth8 can you update/rebase.

Includes implementation, unit tests, documentation fixes and whatsnew.
@markroth8
Copy link
Contributor Author

@jreback: Incorporated suggestions and rebased / pushed.

@jreback jreback closed this in 7e71a44 Mar 21, 2016
jreback added a commit that referenced this pull request Mar 21, 2016
jreback added a commit that referenced this pull request Mar 21, 2016
@markroth8 markroth8 deleted the gh10331 branch March 22, 2016 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Datetime Datetime data dtype Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partial string matching for timestamps with multiindex

3 participants