DOC: add examples of database drivers (GH11686) #11888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Only minor thing is that you have "you also need a database specific driver." could be "you may also need a database specific driver." depending on the database your using. |
|
True, but I think that is only the case for sqlite? (that it is not necessary) Although you actually need one, only it is included in the standard library. But will include that. |
|
A very, very minor thing 😄 |
jorisvandenbossche
force-pushed
the
doc-gh11686
branch
from
36ec0db to
46d7fd0
Compare
jorisvandenbossche
force-pushed
the
doc-gh11686
branch
from
46d7fd0 to
578fd76
Compare
|
Updated! |
|
lgtm |
jorisvandenbossche
added a commit
that referenced
this pull request
Dec 23, 2015
DOC: add examples of database drivers (GH11686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11686