be more careful with half-opened date_range

[thrasibule]

closes #11804

This changes the definition of 'left' and 'right'. If the generated_dates are strictly within (start, end), then changing the value of closed has no impact. Before the code would always remove the leftmost date or rightmost date independently of the value of start and end.

[jreback]

need some tests for this. pls use all of the examples that you provided on gitter.

[jreback]

if not left_closed and len(index) and index[0] == start

[jreback]

also add in closed=None.

Further do this test for start/end on the boundaries & not on the boundaries.

I think you should have 9 possibilities here (3 from closed parm, 3 from if start/end on boundary)

[jreback]

lgtm. can you add a whatsnew note (bug fixes), and squash. ping when green.

[thrasibule]

@jreback done. I wasn't sure if there is a specific order for the whatsnew notes, let me know if I didn't do it right. Thanks.

[jreback]

@thrasibule thanks! no specific order in whatsnew, best to put it in the middle somewhere as that tends to not cause merge conflicts (and the reason I leave space for it)

[thrasibule]

Thanks for merging!