Skip to content

BUG: fix incorrect xticklabels when specifying xticks (GH11529) #11531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2015
Merged

BUG: fix incorrect xticklabels when specifying xticks (GH11529) #11531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.17.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Bug Fixes




- Fix regression in setting of ``xticks`` in ``plot`` (:issue:`11529`).



Expand Down
7 changes: 7 additions & 0 deletions pandas/tests/test_graphics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1237,6 +1237,13 @@ def test_time_series_plot_color_with_empty_kwargs(self):
ax = s.plot()
self._check_colors(ax.get_lines(), linecolors=def_colors[:ncolors])

def test_xticklabels(self):
# GH11529
s = Series(np.arange(10), index=['P%02d' % i for i in range(10)])
ax = s.plot(xticks=[0,3,5,9])
exp = ['P%02d' % i for i in [0,3,5,9]]
self._check_text_labels(ax.get_xticklabels(), exp)


@tm.mplskip
class TestDataFramePlots(TestPlotBase):
Expand Down
2 changes: 1 addition & 1 deletion pandas/tools/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,11 +985,11 @@ def generate(self):
self._make_plot()
self._add_table()
self._make_legend()
self._adorn_subplots()

for ax in self.axes:
self._post_plot_logic_common(ax, self.data)
self._post_plot_logic(ax, self.data)
self._adorn_subplots()

def _args_adjust(self):
pass
Expand Down