-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
Closed
Labels
AlgosNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffCategoricalCategorical Data TypeCategorical Data TypeNeeds TestsUnit test(s) needed to prevent regressionsUnit test(s) needed to prevent regressionsgood first issue
Milestone
Description
From #54789, it seems to me we didn't have any test coverage for Series/DataFrame.value_counts with categoricals. We still don't have any test coverage for these methods where the categorical has missing categories, e.g. pd.Categorical([1, 2, 4], categories=[1, 2, 3, 4])
. Tests for these cases should be added.
Metadata
Metadata
Assignees
Labels
AlgosNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffNon-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diffCategoricalCategorical Data TypeCategorical Data TypeNeeds TestsUnit test(s) needed to prevent regressionsUnit test(s) needed to prevent regressionsgood first issue