Skip to content

Switch to_timedelta argument type from list to Sequence #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Switch to_timedelta argument type from list to Sequence #959

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36dfe7f
GH 956 Allowing sequence type in to_timedelta
loicdiridollou Jul 12, 2024
485ddd0
GH 956 PR feedback
loicdiridollou Jul 15, 2024
a143dcd
GH 956 PR feedback
loicdiridollou Jul 15, 2024
cffcec6
GH 956 PR feedback
loicdiridollou Jul 15, 2024
e6fb19c
Update tests/test_timefuncs.py
loicdiridollou Jul 15, 2024
5eff82e
Fixing lint issue
loicdiridollou Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas-stubs/core/tools/timedeltas.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ from pandas._libs.tslibs.timedeltas import TimeDeltaUnitChoices
from pandas._typing import (
ArrayLike,
RaiseCoerce,
SequenceNotStr,
)

@overload
Expand All @@ -31,8 +32,8 @@ def to_timedelta(
@overload
def to_timedelta(
arg: (
Sequence[float | timedelta]
| list[str | float | timedelta]
SequenceNotStr
| Sequence[float | timedelta]
| tuple[str | float | timedelta, ...]
| range
| ArrayLike
Expand Down
10 changes: 9 additions & 1 deletion tests/test_timefuncs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
from pandas._typing import FulldatetimeDict
else:
FulldatetimeDict = Any
from pandas._typing import TimeUnit
from pandas._typing import (
SequenceNotStr,
TimeUnit,
)

from tests import (
PD_LTE_22,
Expand Down Expand Up @@ -140,6 +143,11 @@ def test_timedelta_series_arithmetic() -> None:
r4: pd.TimedeltaIndex = tds1 / 10.2


def test_timedelta_series_string() -> None:
seq_list: SequenceNotStr[str] = ["1 day"]
check(assert_type(pd.to_timedelta(seq_list), pd.TimedeltaIndex), pd.TimedeltaIndex)


def test_timestamp_timedelta_series_arithmetic() -> None:
ts1 = pd.to_datetime(pd.Series(["2022-03-05", "2022-03-06"]))
assert isinstance(ts1.iloc[0], pd.Timestamp)
Expand Down