Skip to content

gh-529 Fixing Dataframe.insert #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 19, 2023
Merged

gh-529 Fixing Dataframe.insert #543

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8211d0a
Update test_frame.py
ramvikrams Feb 17, 2023
98329e3
Update frame.pyi
ramvikrams Feb 17, 2023
84288e4
Update test_frame.py
ramvikrams Feb 17, 2023
d82efcd
Changed assert_type
ramvikrams Feb 17, 2023
a2e3713
Update test_frame.py
ramvikrams Feb 17, 2023
88d2c49
Update test_frame.py
ramvikrams Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas-stubs/core/frame.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ class DataFrame(NDFrame, OpsMixin):
self,
loc: int,
column,
value: int | ListLike,
value: Scalar | ListLikeU | None,
allow_duplicates: _bool = ...,
) -> None: ...
def assign(self, **kwargs) -> DataFrame: ...
Expand Down
12 changes: 12 additions & 0 deletions tests/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2410,3 +2410,15 @@ def test_in_columns() -> None:
check(assert_type(df.loc[:, cols], pd.DataFrame), pd.DataFrame)
check(assert_type(df[cols], pd.DataFrame), pd.DataFrame)
check(assert_type(df.groupby(by=cols).sum(), pd.DataFrame), pd.DataFrame)


def test_insert_newvalues() -> None:
df = pd.DataFrame({"a": [1, 2]})
gh = df.insert(loc=0, column="b", value=None)
ab = pd.DataFrame({"col1": [1, 2], "col2": [3, 4]})
cd = ab.insert(loc=0, column="newcol", value=[99, 99])
ef = pd.DataFrame({"z": [4, 5, 6]})
hi = ef.insert(loc=0, column="g", value=4)
check(assert_type(gh, None), pd.DataFrame)
check(assert_type(cd, None), pd.DataFrame)
check(assert_type(hi, None), pd.DataFrame)