GH1317 Set defaults #1491
GH1317 Set defaults #1491
Conversation
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Just managed to review pandas-stubs/core/indexes/interval.pyi. Will check the other two files later.
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
Please double check readers.pyi. I do not necessarily make the same suggestion in all overloads.
| memory_map: bool = False, | ||
| float_precision: Literal["high", "legacy", "round_trip"] | None = None, | ||
| storage_options: StorageOptions | None = None, | ||
| dtype_backend: DtypeBackend | _NoDefaultDoNotUse = ..., |
There was a problem hiding this comment.
| dtype_backend: DtypeBackend | _NoDefaultDoNotUse = ..., | |
| dtype_backend: DtypeBackend | no_default = no_default, |
There was a problem hiding this comment.
For those I have kept them simple ... since it would raise a lint for Only simple default values allowed for typed arguments [PYI011], let me know if you want me to go ahead and have a noqa next to it.
There was a problem hiding this comment.
@MarcoGorelli I think you had experience with this. How would you proceed? Thanks.
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
I have reviewed all changes.
| memory_map: bool = False, | ||
| float_precision: Literal["high", "legacy", "round_trip"] | None = None, | ||
| storage_options: StorageOptions | None = None, | ||
| dtype_backend: DtypeBackend | _NoDefaultDoNotUse = ..., |
There was a problem hiding this comment.
@MarcoGorelli I think you had experience with this. How would you proceed? Thanks.
|
@cmp0xff I should have tackled all the feedback, thanks for that! |
cmp0xff
left a comment
cmp0xff
left a comment
There was a problem hiding this comment.
I think that's all comments from my side. Let's wait for https://github.com/pandas-dev/pandas-stubs/pull/1491/files#r2537067277.
Co-authored-by: Yi-Fan Wang <[email protected]>
Co-authored-by: Yi-Fan Wang <[email protected]>
2 participants
assert_type()to assert the type of any return value