Skip to content

Conversation

cmp0xff
Copy link
Contributor

@cmp0xff cmp0xff commented Sep 28, 2025

@cmp0xff cmp0xff mentioned this pull request Sep 28, 2025
2 tasks
@cmp0xff cmp0xff requested a review from Dr-Irv September 28, 2025 20:53
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 29, 2025

Looks like CI is failing because beautifulsoup4 got upgraded. Can you modify pyproject.toml to pin the version to 4.13.5 ? xref pandas-dev/pandas#62492

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 29, 2025

@cmp0xff I merged in #1386 so you'll need to rebase and adjust accordingly to resolve conflicts.

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 29, 2025

Looks like CI is failing because beautifulsoup4 got upgraded. Can you modify pyproject.toml to pin the version to 4.13.5 ? xref pandas-dev/pandas#62492

@cmp0xff apparently this issue got fixed in beautifulsoup4 version 4.14.2, so can you update pyproject.toml accordingly?

Comment on lines 3508 to 3511
pd.Series([True, True, False, False, True]).diff(), "pd.Series[Any]"
),
pd.Series,
object,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We have nowhere else assert_type(..., "pd.Series[type[object]]"). I believe it's better to give pd.Series[Any].
  • pd.Series[bool].diff() gives pd.Series([float("nan"), bool, bool...]) at runtime, with dtype object

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see other comment - with the BooleanDtype, it gives dtype boolean, so let's support that instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we deal with the nullable and non-nullable cases separately? 0a841c7 #1395

@cmp0xff cmp0xff requested a review from Dr-Irv September 29, 2025 18:31
Comment on lines 3508 to 3511
pd.Series([True, True, False, False, True]).diff(), "pd.Series[Any]"
),
pd.Series,
object,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see other comment - with the BooleanDtype, it gives dtype boolean, so let's support that instead.

@cmp0xff cmp0xff requested a review from Dr-Irv September 30, 2025 14:56
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all looking good, but you need to resolve conflicts - probably with to_series(), since that was updated in another PR. And now OffsetSeries is gone, so have to reconcile that as well.

@cmp0xff cmp0xff requested a review from Dr-Irv September 30, 2025 18:37
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmp0xff

@Dr-Irv Dr-Irv merged commit 0042dfd into pandas-dev:main Sep 30, 2025
13 checks passed
@cmp0xff cmp0xff deleted the feature/cmp0xff/drop-interval-series branch September 30, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PeriodSeries, OffsetSeries, IntervalSeries
2 participants