-
-
Notifications
You must be signed in to change notification settings - Fork 150
refactor(series)!: drop IntervalSeries #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(series)!: drop IntervalSeries #1385
Conversation
Looks like CI is failing because |
@cmp0xff apparently this issue got fixed in |
tests/series/test_series.py
Outdated
pd.Series([True, True, False, False, True]).diff(), "pd.Series[Any]" | ||
), | ||
pd.Series, | ||
object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We have nowhere else
assert_type(..., "pd.Series[type[object]]")
. I believe it's better to givepd.Series[Any]
. pd.Series[bool].diff()
givespd.Series([float("nan"), bool, bool...])
at runtime, with dtypeobject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see other comment - with the BooleanDtype
, it gives dtype boolean
, so let's support that instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/series/test_series.py
Outdated
pd.Series([True, True, False, False, True]).diff(), "pd.Series[Any]" | ||
), | ||
pd.Series, | ||
object, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see other comment - with the BooleanDtype
, it gives dtype boolean
, so let's support that instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking good, but you need to resolve conflicts - probably with to_series()
, since that was updated in another PR. And now OffsetSeries
is gone, so have to reconcile that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cmp0xff
Uh oh!
There was an error while loading. Please reload this page.