Skip to content

Conversation

@andfoy
Copy link
Contributor

@andfoy andfoy commented Mar 18, 2020

This PR removes * and / from function arguments when generating snippets.

@andfoy andfoy force-pushed the disable_slash_star branch from 900674d to 160ef28 Compare March 18, 2020 19:21
@goanpeca
Copy link
Contributor

What is this fixing @andfoy ?

@andfoy
Copy link
Contributor Author

andfoy commented Mar 18, 2020

What is this fixing @andfoy ?

Just a quick bug that @ccordoba12 asked me personally to fix

@ccordoba12 ccordoba12 changed the title PR: Remove slash and star from positional snippets Remove slash and star from positional snippets Mar 18, 2020
@ccordoba12
Copy link
Contributor

This removes / and * as snippets for Numpy ufuncs, which makes very little sense:

imagen

Thanks @andfoy for this!

@ccordoba12 ccordoba12 added this to the 0.31.9 milestone Mar 18, 2020
@ccordoba12 ccordoba12 merged commit 21833ea into palantir:develop Mar 18, 2020
@andfoy andfoy deleted the disable_slash_star branch March 18, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants