Escape Jedi path completions #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Mar 17, 2020
| if d.type == 'path': | ||
| path = osp.normpath(d.name) | ||
| path = path.replace('\\', '\\\\') | ||
| path = path.replace('/', '\\/') |
Contributor
There was a problem hiding this comment.
Do these replacements change the way you write paths on Windows and Posix systems in the Spyder editor?
Contributor
Author
There was a problem hiding this comment.
They just escape forward and backward slashes in order to prevent conflicts with the LSP snippets grammar when inserting the text. We're escaping them back in Spyder as well.
Contributor
Author
There was a problem hiding this comment.
Also, paths are normalized in order to preserve backward slashes in Windows and forward ones on POSIX
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes path completions returned by Jedi and escapes them in order to prevent conflicts with the code snippets grammar.
Fixes spyder-ide/spyder#5519