Only add snippet completions when positional args are available #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
changed the title
Contributor
Author
|
I think this is ready @ccordoba12 👍 |
ccordoba12
reviewed
Jan 22, 2020
| snippet += ', ' | ||
| snippet += ')$0' | ||
| completion['insertText'] = snippet | ||
| if len(positional_args) > 1: |
Contributor
There was a problem hiding this comment.
I think we should insert () and put the cursor in the middle of them, in case positional_args == 1.
Contributor
There was a problem hiding this comment.
For positional_args == 0 we need to put the cursor to the right of ()
ccordoba12
changed the title
ccordoba12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the creation of snippets completions with none or single arguments like
..()$0or..(${1:args})$0.Prevents the creation of snippets completions for multi-line imports statements like:
Fixes spyder-ide/spyder#11356