Skip to content

Add new item change catch for MenuItem 'Visible' property #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add new item change catch for MenuItem 'Visible' property #6

wants to merge 2 commits into from

Conversation

murrty
Copy link

@murrty murrty commented Oct 10, 2023 •
edited
Loading

The 'Visible' property is a bit broken.

  • MainMenu will cease to work if one of its items visibility is changed (since 1 destroys the menu and does nothing else)
  • MenuItems with nested items will not pop out the menu if one of the items within that menu has its visibility changed

This patches those known issues, I have not ran into anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@murrty