Skip to content

feat: added support for message provider #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pulphix
Copy link
Contributor

@pulphix pulphix commented Jul 28, 2021

I reworked the message provider support starting from the @tuan-pham branch and Rebase it.
I did update the commits comments to be compliant and fix the tests.

I changed as well the pact file naming removing the _message, checking other language implementation the _message was not in there and the Provider and Broker name with the _message will result alternated. The specification does not say that the queue contract file should contain _message

tuan-pham and others added 30 commits July 26, 2021 09:47
…ass Proxy port param, new endpoints to stop/check proxy
@pulphix
Copy link
Contributor Author

pulphix commented Jul 30, 2021

Hi @tuan-pham @elliottmurray,
I did update the test and now the integration tests are working as expected. the problem was that the contract generated by the consumer was not compliant with the producer messages, basically a typical example of integration issue that pact prevents :).
Please let me know if there are any other changes that I need to apply to the code.

@elliottmurray elliottmurray merged commit 903371b into pact-foundation:master Jul 31, 2021
@elliottmurray
Copy link
Contributor

If you have a chance before I release this can you come on Slack and DM me?

arturoriter pushed a commit to OutSystems/pact-python that referenced this pull request Sep 3, 2021
* feat: message provider implementation

* feat: add basic verify flow

* feat: add missing flask config

* feat: initial flask start setup

* feat: and sample provider test, rename MessageProvider constructor

* feat: move handler to provider

* feat: pass handler as python argument

* feat: pass handler as python argument

* feat: create setup endpoint for message handlers, add setup_state fn, refactor test

* feat: enable context manager in message provider, allow provider to pass Proxy port param, new endpoints to stop/check proxy

* fix: flake8

* fix: revert bad merge to http_proxy; add pydocstyle

* feat: parse content, update readme and test

* test: add missing tests for message provider

* fix: check the pact files exists before running the vefivication

* fix: flake8

* feat: rebase feature from master branch

* fix: remove dead code

* feat: add http_proxy test, replace print with log, use flask localstack to store states

* fix: change PROXY_PORT to 1234 to fix broken build

* fix: flake8

* chore: skip provider test to make the build pass (troubleshooting)

* chore: skip 2 tests that causes BrokenPipeError for investigation

* chore: comment out the broken tests

* fix: change default proxy port to 1234

* feat: updated message consumer test to be compatible with message provider test

* fix: Updated tests that where failing on master branch as well

* feat: ported message_provider to fastapi

* fix: fixed comment

* fix: removed unnecessary pact file updated flask

* fix: added detectcontentlambda-contentprovider.json to .gitignore

Co-authored-by: Tuan Pham <[email protected]>
Co-authored-by: William Infante <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants