Skip to content

Conversation

JP-Ellis
Copy link
Contributor

📝 Summary

Implement compatibility suites around matching rules.

🚨 Breaking Changes

🔥 Motivation

🔨 Test Plan

🔗 Related issues/PRs

@JP-Ellis JP-Ellis self-assigned this Aug 28, 2025
@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 02:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements compatibility test suites for both V3 and V4 matching rules to ensure proper compatibility across Pact specifications. The tests validate various matcher types including array contains, each value, semver, status code, and other matching rules with both positive and negative test cases.

Key changes:

  • Adds comprehensive V3 matching rules test suite with support for boolean, content type, date/time, values, and other matchers
  • Implements V4 matching rules test suite including newer matchers like ArrayContains, EachValue, and semver matchers
  • Provides shared test infrastructure for request/response comparison and mismatch validation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tests/compatibility_suite/test_v4_matching_rules.py Complete V4 matching rules test implementation with fixtures, scenario definitions, and step implementations
tests/compatibility_suite/test_v3_matching_rules.py Complete V3 matching rules test implementation with similar structure but V3-specific matcher support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JP-Ellis JP-Ellis merged commit 9890b28 into main Aug 28, 2025
60 checks passed
@JP-Ellis JP-Ellis deleted the chore/implement-matching-rules-compatibility-suite branch August 28, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4/matching_rules.feature v3/matching_rules.feature
1 participant