Update to renamed v1.12 global method table #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Aug 8, 2025
src/Tricks.jl
Outdated
| mt_edges = Core.Compiler.vect(mt, Tuple{f,Vararg{Any}}) | ||
| else | ||
| mt = Core.GlobalMethods | ||
| mt = Core.methodtable |
Owner
There was a problem hiding this comment.
How about doing
mt = hasproperty(Core, :GlobalMethods) ? Core.GlobalMethods : Core.methodtable # was called this in 1.12-dev/1.12-rc1 before changed in 1.12-rc2
So we don't have to worry about going back and remembering this.
Collaborator
Author
There was a problem hiding this comment.
ooo yes that's better - thanks!
nickrobinson251
commented
Aug 8, 2025
oxinabox
approved these changes
Aug 8, 2025
Owner
|
I have added you as a colaborator |
Pull Request Test Coverage Report for Build 16826232061Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when-rc2is out (should also bump CI version then... what a pain)🙄 JuliaLang/julia#59158
Follow-up to #47