[3/n] [reconfigurator-planning] add and use set_target_release_and_old_repo #8938
+128
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Collaborator
Are we changing this for all tests? Is there some risk there since real systems don't start with it set? |
Contributor
Author
I was planning to update all the
Several reconfigurator-cli tests start with the system at install-dataset -- most notably |
sunshowers
changed the base branch from
sunshowers/spr/main.3n-reconfigurator-planning-add-and-use-set_target_release_and_old_repo
to
main
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Sep 19, 2025
plotnick
reviewed
Sep 19, 2025
Contributor
plotnick
left a comment
plotnick
left a comment
There was a problem hiding this comment.
Not having to guess that initial generation is great, thanks for this.
| // This generation is successively incremented for each TUF repo. We use | ||
| // generation 2 to represent the first generation with a TUF repo | ||
| // attached. | ||
| let target_release_generation = Generation::from_u32(2); |
sunshowers
deleted the
sunshowers/spr/3n-reconfigurator-planning-add-and-use-set_target_release_and_old_repo
branch
charliepark
pushed a commit
that referenced
this pull request
Sep 19, 2025
…d_repo (#8938) For update-related tests, we're going to move to a world where the initial system we start with has a target release set on it. We want to ensure that as part of these tests, we transition from the initial target release to the new one set up by these tests. Add a setter to the `SystemDescription` called `set_target_release_and_old_repo`, and use that in all the update-related tests. As a nice benefit, we don't have to guess that the first non-initial target release generation is 2 (in fact it will soon become 3 since we'll initialize the system with a target release).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For update-related tests, we're going to move to a world where the initial system we start with has a target release set on it. We want to ensure that as part of these tests, we transition from the initial target release to the new one set up by these tests.
Add a setter to the
SystemDescriptioncalledset_target_release_and_old_repo, and use that in all the update-related tests. As a nice benefit, we don't have to guess that the first non-initial target release generation is 2 (in fact it will soon become 3 since we'll initialize the system with a target release).Depends on: