remove extraneous parameter from DnsConfigBuilder service-specific helpers #8264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the service-specific builder methods, the service name was expected as an argument but its only value was to check it was the same name that builder expected. the Clickhouse-related methods then used other names when they would set up multiple records! the only value of the `service_name` argument seems to be as defensive programming, but it seems to primarily be a kind of redundant footgun - if there were a copypaste error this would have caught, we still would define a service as multiple zones on the same sled. this would also error! we would still detect erroneous configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the service-specific builder methods, the service name was expected as an argument but its only value was to check it was the same name that builder expected. the Clickhouse-related methods then used other associated names when they would set up multiple records!
the only value of the
service_nameargument seems to be as defensive programming, but it seems to primarily be a kind of redundant toestubber - if there were a copypaste error this would have caught, we still would likely still catch it. without the service name checks in service-specific helpers, we'd see one service defined as multiple zones on the same sled. this would also error!(one of the two followups i'd talked with @davepacheco about in #8047)