[sled-agent] Remove OmicronZonesConfigLocal
#8220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
May 27, 2025
Contributor
Author
|
Results of testing an upgrade from
|
Contributor
Author
|
Expunging a disk backing a crucible zone and a propolis zone (disk Relevant sled-agent logs after making that blueprint the target - we see the new config ledgered to both internal pools: That immediately triggers the reconciler: First it shuts down the crucible zone: Next we would remove all the datasets on that disk, but we note that we're leaking them instead pending #6177: Next we remove the disk: This wakes up the It also waks up the dump setup task, which now realizes there are only 9 debug datasets left: The rest of the reconciliation proceeds and makes no changes (we didn't add any disks, datasets, or zones). |
Contributor
Author
|
Followup from the disk expungement testing: maybe it's not right that we note that we're leaking datasets and/or would delete them for an expunged disk - we should probably only try to delete datasets if the disk is still present? |
jgallagher
merged commit 4b230b3
into
john/sled-agent-config-reconciler-zone-deps
16 of 17 checks passed
jgallagher
deleted the
john/sled-agent-config-reconciler-cleanup-zones-local
branch
This was referenced Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the zone start and ledgering moved to
sled-agent-config-reconciler, we can remove this type entirely fromsled-agent. I kept the schema check but moved it to thelegacy_configs.rsmodule in the config reconciler, where the same structs still exist to allow conversion of the old ledgers -> the new combined ledger.Builds on top of #8219.